• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make ad_sanitize_html not hardly dependant on a connection being there (thanks to Markus moser for the report)

Also, update documentation and make idioms less awkward.

(this passes automated tests)

Add editor hints + Whitespace changes

    • -34
    • +40
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -1
    • +7
    /openacs-4/packages/chat/tcl/chat-init.tcl
    • -1
    • +7
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Make util_current_location robust such it does not raise an exception when not connected. In these cases, the configured ad_url is returned. This is not perfect either, since it would not work with host-node mapped subsites, and maybe, there are cases, where one wants just information based on the actual connection. so, maybe, one should provide either a higher level API and/or parameterize util_current_location in the future.

extend list of embedded content types

improve comments

improve capitalization and wording in comments

Fix typo

Whitespace changes

Fix typos

Whitespace changes

Fix typos

dotlrn cache reform: move caching from util_memoize into three seperate caches to reduce stress on util_memoize.

These caches are:

- ::dotlrn::dotlrn_cache

Default general purpose cache for dotlrn-wide value (e.g. available applets, etc)

- ::dotlrn::dotlrn_user_cache

Partitioned cache for values specific to a user (e.g. personal_portal_id, theme_id, etc)

- ::dotlrn::dotlrn_community_cache

Partitioned cache for values specific to a community (e.g name, roles, portal_id, etc)

    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
    • -2
    • +6
    /openacs-4/packages/dotlrn/tcl/applets-procs.tcl
    • -63
    • +100
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -3
    • +32
    /openacs-4/packages/dotlrn/tcl/dotlrn-init.tcl
    • -7
    • +22
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
    • -0
    • +8
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.xql
    • -3
    • +1
    /openacs-4/packages/dotlrn/www/member-add-3.tcl
Trailing space cleanup

Whitespace changes

    • -206
    • +206
    /openacs-4/packages/acs-tcl/tcl/widgets-procs.tcl
Fix typos in proc doc

Better separate data from formatting

    • -1
    • +6
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -9
    • +1
    /openacs-4/packages/chat/www/ajax/chat.tcl
Provide tests for public procs: min and max

Normalize indentation

    • -19
    • +19
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
Decouple a bit formatting from data

    • -0
    • +48
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -26
    • +6
    /openacs-4/packages/chat/www/ajax/chat.tcl
Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

    • -64
    • +59
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
Provide tests for public procs: util_escape_quotes_for_csv

Provide tests for public procs: util_commify_number

Whitespace changes

Fix typos

Modernize XoTcl idioms

Refactor test case for util_absolute_path_p

Provide tests for public procs: util_complete_url_p

Fix doc typo

Provide tests for public procs: util_absolute_path_p

Provide tests for public procs: util::trim_leading_zeros