• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove leftover xql and prefer acs_user::get api, as doesn't rely on util_memoize cache

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Remove divergency between oracle and postgres codebase

Remove unnecessary join, as users are always persons and unnecessary stored procedure in order_by as we compute this in the column already

Remove divergency between oracle and postgres, bring all sql inline

Reduce divergency between oracle and postgres codebase

    • -13
    • +0
    /openacs-4/packages/chat/www/user-unban-oracle.xql
    • -3
    • +2
    /openacs-4/packages/chat/www/user-unban.tcl
Moderator is really a generic party and not always a user

Reduce divergency between oracle and postgres codebase

Disambiguate table reference in subquery

Further replace stored procedure with already-available table column

Replace unnecessary stored procedures and casts

Avoid unnecessary stored procedures and casts

Remove leftover xql files

fix example in documentation and small code cleanup

Avoid unnecesary existence checks

Whitespace changes

Avoid unnecesary existence checks

Whitespace changes

Fix wrong bracket

Avoid unnecesary existence checks

align comment to implementation; be more explicit on optional/default values

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

Whitespace changes

    • -5
    • +5
    /openacs-4/packages/chat/www/search-2.tcl
Avoid unnecesary existence checks.

    • -4
    • +2
    /openacs-4/packages/chat/www/search-2.tcl
Remove duplication and use more api

This code could not work on oracle... not sure if this was considered, or people just assumed fts was a Postgres-only thing

Whitespace cleanup

Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

Use api to remove difference between oracle and postgres code and replace array with dict idioms

Remove leftover xql files